Support @scope#434
Merged
aeschli merged 8 commits intomicrosoft:mainfrom Apr 24, 2025
Merged
Conversation
aeschli
approved these changes
Apr 24, 2025
Collaborator
|
Great job, very nice! |
Collaborator
|
If you want to look into a PR that adds hover and completion support for |
lszomoru
approved these changes
Apr 24, 2025
Collaborator
|
BTW, microsoft/vscode-custom-data#115 adds |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incorrect autocomplete within the @scope block was driving me up the wall so here you go :P
Addresses #406
Replaced the
selectorToMarkedString()flagOptsparameter (and associated references) withselectorContextsto better represent the 'context' of a selector in general and allow for any number of contexts, such as nested@mediaand@scope.*One thing I did notice is that @scope isn't being suggested in autocomplete, and I believe that this is because it's missing from
webCustomData.ts, which is from a different repo. Currently looking into that and once I've raised something there I'll update this.Aside from that, I think this is everything that needs to be done on this end to support
@scope.Not much experience contributing to OSS and unfamiliar with the repo, so feedback is appreciated.
*I also noticed
@layerwas missing navigation/hover support while I was there so lmk if you'd like me to add that to this PR, or if you'd prefer that to be in a separate PR.